Skip to content

esql async search type improvements#256523

Merged
rudolf merged 1 commit into
elastic:ralph/typed-es-client-methodsfrom
lukasolson:ralph/typed-es-client-methods
Mar 9, 2026
Merged

esql async search type improvements#256523
rudolf merged 1 commit into
elastic:ralph/typed-es-client-methodsfrom
lukasolson:ralph/typed-es-client-methods

Conversation

@lukasolson
Copy link
Copy Markdown
Contributor

Summary

Fixing some type issues in #256456.
This is PR against the branch from that PR (not main)

@lukasolson lukasolson self-assigned this Mar 6, 2026
@lukasolson lukasolson requested review from a team as code owners March 6, 2026 18:01
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 6, 2026

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #3 / BackfillClient constructor should register backfill task type
  • [job] [logs] Jest Tests #3 / BackfillClient constructor should register backfill task type
  • [job] [logs] src/platform/test/functional/apps/discover/esql/config.ts / discover/esql discover esql view inspector shows Discover and Lens requests in Inspector
  • [job] [logs] FTR Configs #82 / discover/esql discover esql view inspector shows Discover and Lens requests in Inspector
  • [job] [logs] FTR Configs #84 / discover/esql discover esql view inspector shows Discover and Lens requests in Inspector
  • [job] [logs] FTR Configs #98 / discover/esql discover esql view inspector shows Discover and Lens requests in Inspector
  • [job] [logs] FTR Configs #164 / discover/esql discover esql view inspector shows Discover and Lens requests in Inspector
  • [job] [logs] src/platform/test/functional/apps/discover/esql/config.ts / discover/esql discover esql view inspector shows Discover and Lens requests in Inspector
  • [job] [logs] FTR Configs #84 / discover/esql discover esql view inspector shows Discover and Lens requests in Inspector
  • [job] [logs] FTR Configs #98 / discover/esql discover esql view inspector shows Discover and Lens requests in Inspector
  • [job] [logs] FTR Configs #82 / discover/esql discover esql view inspector shows Discover and Lens requests in Inspector
  • [job] [logs] FTR Configs #164 / discover/esql discover esql view inspector shows Discover and Lens requests in Inspector
  • [job] [logs] Jest Tests #8 / performEsqlRequest returns results immediately when the async query completed
  • [job] [logs] Jest Tests #8 / performEsqlRequest returns results immediately when the async query completed

Metrics [docs]

✅ unchanged

History

cc @lukasolson

Copy link
Copy Markdown
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I see there are some test failures, but looks like they just need minor updates to account for e.g. drop_null_columns changes.

@rudolf rudolf merged commit f6ae463 into elastic:ralph/typed-es-client-methods Mar 9, 2026
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants